Align with cluster-compare v4.19.0 diff #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up with the following diff in the last rebuild: $ git diff ansible/roles/telco-core-manifests/templates/extra-manifests/sctp_module_mc.yaml
diff --git a/ansible/roles/telco-core-manifests/templates/extra-manifests/sctp_module_mc.yaml b/ansible/roles/telco-core-manifests/templates/extra-manifests/sctp_module_mc.yaml
index 17b1e0b..fa4969a 100644
--- a/ansible/roles/telco-core-manifests/templates/extra-manifests/sctp_module_mc.yaml
+++ b/ansible/roles/telco-core-manifests/templates/extra-manifests/sctp_module_mc.yaml
@@ -10,17 +10,16 @@ metadata:
spec:
config:
ignition:
- version: 2.2.0
+ version: 3.2.0
storage:
files:
- - contents:
- source: data:,
- verification: {}
- filesystem: root
- mode: 420
- path: /etc/modprobe.d/sctp-blacklist.conf
- - contents:
- source: data:text/plain;charset=utf-8;base64,c2N0cA==
- filesystem: root
- mode: 420
- path: /etc/modules-load.d/sctp-load.conf
+ - path: /etc/modprobe.d/sctp-blacklist.conf
+ mode: 420
+ overwrite: true
+ contents:
+ source: data:,
+ - path: /etc/modules-load.d/sctp-load.conf
+ mode: 420
+ overwrite: true
+ contents:
+ source: data:text/plain;charset=utf-8;base64,c2N0cA==Let me know if cluster-compare was happy with it and if you need help adjusting this PR to match. |
|
It is not accusing a diff in the ignition version. I think we can close this. |
|
Closing in favor of #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster-compare (v4.19.0) is accusing a diff from this manifest, which also seems to have a typo (with the wrong ignition config version) in the reference:
CC: @imiller0